Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test against latest versions of k8s #620

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

consideRatio
Copy link
Collaborator

No description provided.

@martindurant
Copy link
Member

Good idea! Is there a reason to want to test against multiple versions of kubernetes?

@consideRatio
Copy link
Collaborator Author

consideRatio commented Oct 13, 2022

Is there a reason to want to test against multiple versions of kubernetes?

Yepp! The Helm chart that we test is compatible with some versions of k8s, but not all, because of resources evolve over time.

By testing against the oldest known supported version of k8s and newest version of k8s, we ensure people installing the Helm chart and upgrading to newer versions of k8s won't run into issues.

The kind of changes made over time are often quite simple - but essential for function. Here is an example of such maintenance: jupyterhub/zero-to-jupyterhub-k8s#920


EDIT: My experience is that we need to test against the oldest and the latest, and something in between to pinpoint the difference that caused one test to fail if that happens. We also want a dedicated test for testing if we can upgrade the Helm chart from some older version to some newer version. To conclude, I think we can remove one of the four tests currently.

@martindurant
Copy link
Member

we need to test against the oldest and the latest.

makes sense

@consideRatio
Copy link
Collaborator Author

About to open another chore maintenance PR where I want to test against modern versions, I'll go for a merge here.

@consideRatio consideRatio merged commit dee2db4 into dask:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants