Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n_iter_ attribute to estimators #79

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pentschev
Copy link
Member

@pentschev pentschev commented Mar 20, 2019

After this is merged, Dask-ML must be adapted to this change as well.

https://github.com/dask/dask-ml/blob/master/dask_ml/linear_model/glm.py#L187

Solves #77.

@mrocklin
Copy link
Member

cc @jrbourbeau @cicdw

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @pentschev, this PR looks really good!

Minor comment: could you please add an n_iter_ attribute to the estimator docstrings

Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check

dask_glm/algorithms.py Outdated Show resolved Hide resolved
@pentschev
Copy link
Member Author

Minor comment: could you please add an n_iter_ attribute to the estimator docstrings

Yes, thanks for pointing that I forgot it.

Also, as you mentioned, these changes will cause breakage in dask-ml. Do you have an interest in updating the estimators over there too? Definitely no obligation though, just wanted to check

Yes, I planned to do that once this was merged, I think there's no point in already opening an PR there before this gets reviewed here.

@jrbourbeau
Copy link
Member

Yes, I planned to do that once this was merged

Awesome, thank you @pentschev

@pentschev
Copy link
Member Author

From my side, this is ready for another review/merge.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pentschev
Copy link
Member Author

Are we good to merge this?

Base automatically changed from master to main February 10, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants