Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DeprecationWarnings when importing scipy.ndimage filter functions #261

Merged
merged 3 commits into from
May 11, 2022

Conversation

fbunt
Copy link
Contributor

@fbunt fbunt commented Apr 1, 2022

Fix #260

Import from scipy.ndimage rather than scipy.ndimage.filters as the filters namespace is now deprecated.

Import from `scipy.ndimage` rather than `scipy.ndimage.filters` as
the filters namespace is now deprecated.
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@jakirkham
Copy link
Member

ok to test

@fbunt
Copy link
Contributor Author

fbunt commented Apr 1, 2022

Hmm It looks like i missed some based on the test output

@fbunt
Copy link
Contributor Author

fbunt commented Apr 2, 2022

Looks like I got all of the filters DeprecationWarnings. scipy.ndimage.fourier has the same issue though. Would you like me to do the same for that namespace? The fourier functions appear to have been importable from the scipy.ndimage namespace at least as far back as 0.19.1 as well.

@fbunt
Copy link
Contributor Author

fbunt commented Apr 4, 2022

I don't think the docs build CI failure is due to my changes. It seems to happen regardless. I found these issues discussing it:

@GenevieveBuckley
Copy link
Collaborator

Thank you for the PR @fbunt!

I agree, I think the docs build failure is unrelated. I suspect the environment_doc.yml file is very old, and we might need to update the version numbers in it.

@GenevieveBuckley
Copy link
Collaborator

Let's try the same fix suggested here

Pinning to Jinja2<3.1 fixed it for our project. At first I thought 3.0.3 broke it too until I saw something else undoing my pin in the log; you should check again.

The CI tests are running again now, so if they all pass this time we should be ready to merge this PR.

@fbunt
Copy link
Contributor Author

fbunt commented May 11, 2022

Thanks!

@jakirkham jakirkham merged commit 58b9aa0 into dask:main May 11, 2022
@jakirkham
Copy link
Member

Thank you both! 🙏

@GenevieveBuckley GenevieveBuckley mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings for import from scipy.ndimage.filters namespace
4 participants