-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum versions in dependencies
, remove scikit-image & slicerator dependency
#374
Conversation
Also assuming |
@GenevieveBuckley could you please review? |
Yes, I think the PR just fell out of date between it being opened and merged.
I added them because they are included in the environment yaml files. I was trying to make sure it wouldn't matter which method someone used to install it, you'd still get something that matches. That might not have been the best thing to do though. I also thought for some reason that scikit-image was required for a new-ish function, but I can't actually see it being imported anywhere (including the tests). So maybe it shouldn't be there at all. I think slicerator is a dependency of one of our other dependencies, so it might not be a thing we need to worry about in the pyproject.toml at all. Like I said, I was just trying to match the environment files, but that's maybe not the best strategy. |
I also saw this issue from Mark about switching from dask to dask-core: conda-forge/dask-image-feedstock#16 |
* `scikit-image` is a test-only dependency * `slicerator` is already pulled in by `pims` So drop both of these as they shouldn't be needed at runtime.
No worries. It's better to move forward with changes (like Think Regarding The Maybe there is a better way to manage the dependencies here and call out what is needed for testing to make it clearer. Open to thoughts on that, but maybe we can discuss in a new issue? |
Thank you for doing this @jakirkham |
Happy to help 🙂 |
dependencies
dependencies
, remove scikit-image & slicerator dependency
It looks like a few dependencies had higher minimum versions when using
setup.py
dask-image/setup.py
Lines 31 to 39 in 243fb0a
Though we wound up with older versions after switching to
pyproject.toml
dask-image/pyproject.toml
Lines 26 to 35 in 49d9c33
Guessing this is just because the
pyproject.toml
PR has fallen out of date in this area and we missed itSo went ahead and bumped these. Though please let me know if I'm missing something