Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dask-image with pip on RTD #377

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 21, 2024

  • Install on RTD with pip (keeps the git repo clean, which likely causes the ".dev0" version issue)
  • Disable setuptools-scm's version_scheme guess (states versions in terms of distance passed the old version)

@jakirkham jakirkham marked this pull request as ready for review May 21, 2024 05:22
@GenevieveBuckley
Copy link
Collaborator

Looks good, happy for us to give it a go and see if that fixes things.

The only other relevant part of the code base is the docs/conf.py lines:
https://github.com/dask/dask-image/blob/main/docs/conf.py#L70-L73

I don't know whether RTD is pulling in version or release and don't know how to find out, but that's one other thing to check if merging this PR doesn't help.

@jakirkham
Copy link
Member Author

Sounds good. Let's see what happens. Will do another tag to test. Hopefully we can iron out these remaining release hiccups together 🙂

@jakirkham jakirkham merged commit 0b5523f into dask:main May 21, 2024
18 checks passed
@jakirkham jakirkham deleted the rtd_install_w_pip branch May 21, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants