Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ? #127

Closed
guillaumeeb opened this issue Aug 14, 2018 · 15 comments
Closed

Release ? #127

guillaumeeb opened this issue Aug 14, 2018 · 15 comments

Comments

@guillaumeeb
Copy link
Member

guillaumeeb commented Aug 14, 2018

#63 has been merged after the previous release. I think we should make a new one to account this change and other smaller ones. Moreover, without #63, adaptive seems to be broken as highlighted in #126, and probably #122.

@guillaumeeb
Copy link
Member Author

ping @mrocklin @jhamman @lesteve

Maybe we should wait for #118 #131 and #135, that should get in soon.

@lesteve
Copy link
Member

lesteve commented Aug 24, 2018

What is the status of #97? I haven't followed closely but my feeling is that adaptative still have some quirks that would be nice to iron out.

@jhamman
Copy link
Member

jhamman commented Aug 30, 2018

Status of #97. Not done. Could use some beta testers / new ideas. We can make a release without those changes but I'd like to make sure a few others understand the complications therein.

@guillaumeeb
Copy link
Member Author

I think we should move on and release soon. I've never done that, but can try tomorrow.

@mrocklin
Copy link
Member

mrocklin commented Sep 5, 2018

I would be happy to help walk you through it. I typically follow the checklist here: https://github.com/dask/dask/blob/master/docs/release-procedure.md

I'll need to add you as a maintainer of the project on PyPI. Do you have an account there already?

@guillaumeeb
Copy link
Member Author

Nope, don't think so, will create it.

@guillaumeeb
Copy link
Member Author

Done, same login as github.

@mrocklin
Copy link
Member

mrocklin commented Sep 5, 2018 via email

@guillaumeeb
Copy link
Member Author

Generally yes. Don't know twine though, and conda forge part looks a bit more complex, but that should be ok.

@mrocklin
Copy link
Member

mrocklin commented Sep 5, 2018 via email

@guillaumeeb
Copy link
Member Author

Perfect, will try tomorrow and get to you if I encounter some issue. Thanks !

That leaves some hours for others to chime in if against a release now.

@willirath
Copy link
Collaborator

conda forge part looks a bit more complex

This is not necessarily true any more: You can skip the rerendering part and trigger this with a comment in the discussion after creating the PR with just the recipe/meta.yaml updated to the new version (hash, version number, reset build number):

https://conda-forge.org/docs/webservice.html#conda-forge-admin-please-rerender

@mrocklin
Copy link
Member

mrocklin commented Sep 6, 2018 via email

@guillaumeeb
Copy link
Member Author

dask-jobqueue (0.4.0) pushed to PyPI.

Waiting for conda-forge as recommended by @mrocklin.

@guillaumeeb
Copy link
Member Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants