-
-
Notifications
You must be signed in to change notification settings - Fork 146
Closed
Description
Two things to look at:
- none build which mainly do code formatting checks (see Asynchronous job submission and removal #610 (comment)).
- Docker image builds, might be due to Python version problem. (Make cli worker parameter flexible #606 (comment))
Activity
jrueb commentedon Aug 4, 2023
One thing I noticed is that this looks really outdated
dask-jobqueue/.pre-commit-config.yaml
Line 7 in 4bbd0a0
flake8 moved to github years ago, see https://flake8.pycqa.org/en/latest/release-notes/4.0.0.html "Migrate from GitLab to GitHub"
kaelancotter commentedon Mar 13, 2024
Are you looking for help with this?
guillaumeeb commentedon Mar 13, 2024
Definitely!
kaelancotter commentedon Mar 15, 2024
Created PR 636 to resolve CI failures.
Unfortunately CI fails in the PR since the updated images aren't pushed from the build step if its a PR - so CI action is still using the old docker images.
LMK if there's another direction I should take this to deal with the docker image catch-22
Specific to SGE tests - adding the --full-trace flag got rid of the seg fault, but I don't have a good root cause analysis.
This PR also doesn't address CI for documentation.
Issue #613 - update conda env setup for CI images (#636)
jacobtomlinson commentedon Aug 21, 2024
CI is in a much better place. #653 is still outstanding but I think we can close this issue in favour of that one.