Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require all cores on the same node #177

Merged
merged 1 commit into from
Oct 17, 2018
Merged

require all cores on the same node #177

merged 1 commit into from
Oct 17, 2018

Conversation

louisabraham
Copy link
Contributor

willirath
willirath approved these changes Oct 17, 2018
View reviewed changes
Copy link
Collaborator

@willirath willirath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

guillaumeeb
guillaumeeb approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@guillaumeeb guillaumeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louisabraham!
Just unsure of the if ncpus > 1, but if you feel it's necessary, then let's go with it, I'm no LSF user!

@guillaumeeb
Copy link
Member

Thanks @willirath for your involvement too!

@louisabraham
Copy link
Contributor Author

Just unsure of the if ncpus > 1, but if you feel it's necessary, then let's go with it, I'm no LSF user!

I have absolutely no idea whether it does something, it's up to you to keep it or not.

It just cannot hurt and I don't trust old software that is not open source…

@guillaumeeb guillaumeeb merged commit a802f6d into dask:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumeeb guillaumeeb guillaumeeb approved these changes

@willirath willirath willirath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSFCluster worker doesn't execute all threads on the same node
3 participants
@louisabraham @guillaumeeb @willirath