Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DaskJob pod with Kubernetes Job #745

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Matt711
Copy link
Member

@Matt711 Matt711 commented Jun 27, 2023

Closes #695. This PR replaces the Pod created from a DaskJob CRD with a Job. This allows us to use some of the existing functionality of K8s Jobs.

@bstadlbauer
Copy link
Collaborator

bstadlbauer commented Jun 27, 2023

Hey @Matt711!
Would you mind if I try whether things still work with the Flyte dask plugin (this thing) once you're ready?
It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin

cc @jacobtomlinson

@Matt711
Copy link
Member Author

Matt711 commented Jun 27, 2023

Hey @Matt711! Would you mind if I try whether things still work with the Flyte dask plugin (this thing) once you're ready? It makes some assumptions around the job here, in particular the job-runner pod name, etc. So would be nice if this wouldn't be breaking the plugin

cc @jacobtomlinson

Yeah, no problem!

@Matt711 Matt711 marked this pull request as ready for review June 27, 2023 17:23
"apiVersion": "batch/v1",
"kind": "Job",
"metadata": metadata,
"spec": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want our spec to replace this, rather than the "spec" within "template".

That does mean we need to modify our CRDs to ref a JobSpec instead. That is a breaking change to our CRDs so we might need to think about how to bump the version there.

$ref: 'python://k8s_crd_resolver/schemata/k8s-1.21.1.json#/definitions/io.k8s.api.core.v1.PodSpec'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backoffLimit to DaskJobs
3 participants