Append any URL query args to dashboard URL paths #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you enter
http://1.2.3.4/status?token=abc
as the dashboard address, the existing code will attempt to hithttp://1.2.3.4/status?token=abc/individual-plots.json
.This makes it instead hit
http://1.2.3.4/individual-plots.json?token=abc
, and also append?token=abc
to the paths of the individual plots.With this change, it's possible to use dask-labextension with a dashboard that has token-based auth. (We're now doing this in Coiled, using an NGINX sidecar in front of the dashboard.)