Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few errors with upstream pandas and pyarrow #10412

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix a few errors with upstream pandas and pyarrow #10412

merged 2 commits into from
Jul 21, 2023

Conversation

j-bennet
Copy link
Contributor

Fixes the following:

dask/dataframe/io/tests/test_parquet.py::test_roundtrip_arrow[df8]: [XPASS(strict)] https://github.com/apache/arrow/issues/15079
dask/dataframe/io/tests/test_parquet.py::test_roundtrip_arrow[df9]: [XPASS(strict)] https://github.com/apache/arrow/issues/15079
dask/dataframe/io/tests/test_parquet.py::test_pandas_timestamp_overflow_pyarrow: Failed: DID NOT RAISE <class 'pyarrow.lib.ArrowInvalid'>
dask/dataframe/tests/test_groupby.py::test_groupby_numeric_only_supported[disk-None-median]: TypeError: Cannot convert ['foo' 'foo'] to numeric
dask/dataframe/tests/test_groupby.py::test_groupby_numeric_only_supported[disk-False-median]: TypeError: Cannot convert ['foo' 'foo'] to numeric
dask/dataframe/tests/test_groupby.py::test_groupby_numeric_only_supported[tasks-None-median]: TypeError: Cannot convert ['foo' 'foo'] to numeric
dask/dataframe/tests/test_groupby.py::test_groupby_numeric_only_supported[tasks-False-median]: TypeError: Cannot convert ['foo' 'foo'] to numeric

Related:

  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet j-bennet mentioned this pull request Jul 15, 2023
Merged
hendrikmakait
hendrikmakait approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-bennet!

@hendrikmakait hendrikmakait merged commit fb5c215 into dask:main Jul 21, 2023
20 of 22 checks passed
@j-bennet j-bennet deleted the j-bennet/upstream-errors branch July 21, 2023 15:42
phofl added a commit to phofl/dask that referenced this pull request Jul 24, 2023
@phofl
Revert "Fix a few errors with upstream pandas and pyarrow (dask#10412)"
02dcbd6 
This reverts commit fb5c215.
j-bennet added a commit to j-bennet/dask that referenced this pull request Jul 28, 2023
@j-bennet
Fix a few errors with upstream pandas and pyarrow (dask#10412)
1466555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

Assignees
No one assigned
Labels
dataframe io upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-bennet @hendrikmakait