Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_groupby_unaligned_index for pandas 2.0 #9963

Merged

Conversation

j-bennet
Copy link
Contributor

Fixes an upstream failure with Pandas 2.0:

dask/dataframe/tests/test_groupby.py::test_groupby_unaligned_index[disk]: AssertionError: assert FrozenList(['a', None]) == FrozenList([None])
  At index 0 diff: 'a' != None
  Left contains one more item: None
  Full diff:
  - FrozenList([None])
  + FrozenList(['a', None])
  ?             +++++
dask/dataframe/tests/test_groupby.py::test_groupby_unaligned_index[tasks]: AssertionError: assert FrozenList(['a', None]) == FrozenList([None])
  At index 0 diff: 'a' != None
  Left contains one more item: None
  Full diff:
  - FrozenList([None])
  + FrozenList(['a', None])
  ?             +++++
  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet j-bennet requested a review from jrbourbeau February 15, 2023 06:00
@j-bennet j-bennet changed the title Fix test_groupby_unaligned_index for pandas 2.0 compatibility Fix test_groupby_unaligned_index for pandas 2.0 compatibility Feb 15, 2023
@jrbourbeau jrbourbeau changed the title Fix test_groupby_unaligned_index for pandas 2.0 compatibility Fix test_groupby_unaligned_index for pandas 2.0 Feb 15, 2023
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-bennet!

@jrbourbeau jrbourbeau merged commit 2a5a159 into dask:main Feb 15, 2023
@j-bennet j-bennet deleted the j-bennet/9736-fix-groupby-unaligned-index branch February 16, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants