Skip to content

Commit

Permalink
Cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
hendrikmakait committed Sep 16, 2022
1 parent 4f33c16 commit 9c9438e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
6 changes: 0 additions & 6 deletions distributed/stealing.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,12 +417,6 @@ def balance(self) -> None:
and ws not in potential_thieves
]
if not potential_victims:
# TODO: Unclear how to reach this and what the implications
# are. The return is only an optimization since the for-loop
# below would be a no op but we'd safe ourselves a few loop
# cycles. Unless any measurements about runtime, occupancy,
# etc. changes we'd not get out of this and may have an
# unbalanced cluster
return
if len(potential_victims) < 20:
potential_victims = sorted(
Expand Down
3 changes: 0 additions & 3 deletions distributed/tests/test_steal.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ def block(x, event):
client=True,
nthreads=[("127.0.0.1", 1)] * 2,
config={"distributed.scheduler.work-stealing-interval": "10ms"},
timeout=10,
)
async def test_allow_tasks_stolen_before_first_completes(c, s, a, b):
# https://github.com/dask/distributed/issues/5564
Expand Down Expand Up @@ -756,12 +755,10 @@ async def test_restart(c, s, a, b):
await asyncio.sleep(0.01)

steal = s.extensions["stealing"]
# assert any(st for st in steal.stealable_all)
assert any(x for L in steal.stealable.values() for x in L)

await c.restart()

# assert not any(x for x in steal.stealable_all)
assert not any(x for L in steal.stealable.values() for x in L)


Expand Down

0 comments on commit 9c9438e

Please sign in to comment.