Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate performance issues in profiler #4091

Open
jcrist opened this issue Sep 1, 2020 · 2 comments
Open

Investigate performance issues in profiler #4091

jcrist opened this issue Sep 1, 2020 · 2 comments

Comments

@jcrist
Copy link
Member

jcrist commented Sep 1, 2020

This is a bit vague, apologies. We've received a report of high memory (multi GiB) usage that was resolved by reducing the frequency of the profiler in the workers. The user used tracemalloc and noted that many large allocations were occurring in the profiler. Reducing the frequency of profile info collections reduced the memory usage significantly.

See PrefectHQ/prefect#3238 and https://stackoverflow.com/questions/63680134/growing-memory-usage-leak-in-dask-distributed-profiler/63680548#63680548

Other related issues also seem to point to performance overhead in the profiler

@quasiben
Copy link
Member

quasiben commented Sep 2, 2020

Once we have a reproducer I'd be happy to help investigate

@martindurant
Copy link
Member

cc @TomAugspurger , perhaps related to the profiler holding references during buffer mutation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants