Add profile page for event loop thread #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mrocklin
force-pushed
the
profile-loop
branch
3 times, most recently
from
6d055fc to
0906bc6
Compare
This adds a thread to each event loop that periodically polls the state of the event loop and maintains a time series of profile information. This data is served on the profile-server route of the bokeh servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have nice statistical profiling for the worker threads of each worker that is visible from the bokeh diagnostic pages. However it would be nice to also get this same kind of information about the main administrative thread within the scheduler and workers themselves. This will help us to understand performance costs generally and tune the scheduler and worker codes.
This PR copies and modifies the profile code to operate on each event loop and provides a new route (currently not advertised) on the dashboard. This helps us to understand the costs of things like asyncio and how they affect our general performance.