Update TaskState documentation about dependents attribute #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The scheduler uses the attribute |
|
IIUC Gil this is code that you have been working with lately. Maybe you have thoughts on this change? 🙂 |
gforsyth
approved these changes
Feb 4, 2021
|
Thanks Florian for the PR and Gil for the review! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this mechanism should be refined but currently
dependentsis a dynamic data structure and this should be reflected in the docs.For dependencies we have already a dynamic equivalent with
waiting_for_dataand I believe we should establish a similar mechanism for the dependents since this is primarily used to determine whether or not a key is allowed to be forgotten. In the meantime, a more accurate docstring should helpxref #4413