Handle stream is None
case in TCP comm finalizer
#4631
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Dask users reported running into the following error coming from the
TCP
comm finalizer methodLooking at the
TCP
comm, there are some code paths where we will set the stream toNone
:distributed/distributed/comm/tcp.py
Lines 201 to 205 in 8942856
In particular, when
sys.is_finalizing()
isTrue
we don't raise an error and could end up withwhen the finalizer for the comm is run during interpreter shutdown.
This PR adds a check to the corresponding
finalize
function to make surestream is not None
before attempting to callstream.close()