Add option for timestamps from output of Node.get_logs
#4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Jun 21, 2021
|
Are there any other user-facing places where we might want to add timestamps for logs? Currently this only impacts the perf report and Jupyter notebook representation. |
|
Will probably want to wait on #4941 before we merge this |
|
Could we rerun tests on this? Should be good now that #4941 is merged |
fjetter
reviewed
Jul 14, 2021
|
Thanks for the suggestion @fjetter, think this should be good to merge now |
fjetter
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4909, it would be nice if the output of
Node.get_logshad optional timestamps, which could be used to filter the logs in the performance report and/or be added as information for the user.black distributed/flake8 distributed/isort distributed