Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove default comm timeout for tests #5389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Remove default comm timeout for tests #5389

wants to merge 1 commit into from

Conversation

jrbourbeau
Copy link
Member

I'm curious what impact this will have on CI.

On main I can reproduce the distributed/tests/test_stress.py::test_stress_creation_and_deletion failure we've been seeing in CI lately using pytest-xdist / pytest-repeat

pytest distributed/tests/test_stress.py::test_stress_creation_and_deletion --runslow -n10 --count=20 -x

xref #5388. With these changes, at least locally on my laptop, test_stress_creation_and_deletion passes.

@jrbourbeau jrbourbeau requested a review from fjetter as a code owner January 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrbourbeau