Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve contextvars during comm offload #5486

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

gjoseph92
Copy link
Collaborator

Not currently used for anything, so debatable if we want to merge this now. However, this will eventually help with #5485, I had already written the code in #5473, and perhaps it'll save someone else future confusion.

Implementation referenced from python/cpython#9688

Originally I used this for 30af07e, which I thought about opening a PR for. However, I think we should take a more general approach, namely #5485 and cleaning up all the inconsistencies around get_client(), Client.current(), default_client(), and get_worker().

cc @crusaderky @fjetter

  • Tests added / passed
  • Passes pre-commit run --all-files

Helps with setting the current client in worker while deserializing. Implementation referenced from python/cpython#9688
@crusaderky crusaderky merged commit f6796f7 into dask:main Nov 15, 2021
@crusaderky
Copy link
Collaborator

LGTM - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants