Actually support uvloop in distributed #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oof, looks like we were accidentally relying on creating event loops in lots of places. More to do here. |
|
Hmmm, this will now pass (at least on linux) any specific test, but fails on a full run. Will have to dig in more later. |
Previously distributed relied on the AnyThreadEventLoopPolicy, which configuring uvloop would override, preventing distributed from actually working with uvloop. We remove the need for `AnyThreadEventLoopPolicy` and fixup uvloop configuration to fix this. This also standardizes the `.asynchronous` and `sync` methods on classes that support them. This is currently `Client`, `Cluster`, and `Semaphore` for some reason. `Event`/`Lock`/... don't have these methods, not sure why semaphore does, but I left it as is for now.
jcrist
force-pushed
the
uvloop-actually-works
branch
from
def51f6 to
538ab99
Compare
|
I believe the windows failures are due to flaky tests. This should be ready for review. |
|
The win py3.7 failure is a known flaky test. I cannot classify the win py3.9 failure. It fails during teardown since some client instance is still around. I don't think this is a flaky test but it is hard to tell since there is also a timeout involved |
fjetter
approved these changes
Nov 23, 2021
|
Thanks for the review Florian! |
3 tasks
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously distributed relied on the AnyThreadEventLoopPolicy,
which configuring uvloop would override, preventing distributed from
actually working with uvloop. We remove the need for
AnyThreadEventLoopPolicyand fixup uvloop configuration to fix this.This also standardizes the
.asynchronousandsyncmethods on classesthat support them. This is currently
Client,Cluster, andSemaphorefor some reason.Event/Lock/... don't have thesemethods, not sure why semaphore does, but I left it as is for now.
Fixes #5309, supersedes #5312.