-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix distributed
pre-release's distributed-impl
constraint
#5867
Fix distributed
pre-release's distributed-impl
constraint
#5867
Conversation
If we want to catch issues like this in the future, I think adding |
We could add it to |
Unit Test Results 12 files ±0 12 suites ±0 7h 19m 2s ⏱️ - 2m 40s For more details on these failures, see this check. Results for commit aa5381f. ± Comparison against base commit a0f2af6. ♻️ This comment has been updated with latest results. |
Seeing the following issue on CI: Traceback (most recent call last):
File "/usr/share/miniconda3/envs/test/bin/conda-mambabuild", line 10, in <module>
sys.exit(main())
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/boa/cli/mambabuild.py", line 239, in main
call_conda_build(action, config)
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/boa/cli/mambabuild.py", line 211, in call_conda_build
result = api.build(
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda_build/api.py", line 186, in build
return build_tree(
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda_build/build.py", line 3099, in build_tree
test(pkg, config=metadata.config.copy(), stats=stats)
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda_build/build.py", line 2889, in test
environ.create_env(metadata.config.test_prefix, actions, config=metadata.config,
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda_build/environ.py", line 904, in create_env
display_actions(actions, index)
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda/exports.py", line 236, in display_actions
actions['LINK'] = [index[d] for d in actions['LINK']]
File "/usr/share/miniconda3/envs/test/lib/python3.8/site-packages/conda/exports.py", line 236, in <listcomp>
actions['LINK'] = [index[d] for d in actions['LINK']]
KeyError: Dist(channel='dask/label/dev', dist_name='dask-core-2022.02.1a220225-py_gefa6b730_40', name='dask-core', fmt='.tar.bz2', version='2022.02.1a220225', build_string='py_gefa6b730_40', build_number=40, base_url=None, platform=None) |
Yeah I'm not sure what this is, going to push up a blank commit just to verify if this is a reproducible issue and not flaky |
Looks like it was a flaky error 🙂 should be good here |
Interesting ok well let's keep an eye on it in case it resurfaces 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Charles! 😄
Merging since only the Conda build is relevant here |
With #5865, I updated the build string of the
distributed-impl
packages we are producing, but forgot to update thedistributed
constraint ofdistributed-impl
accordingly - this PR does that, allowing thedistributed-impl
package to work as expected.cc @jakirkham
pre-commit run --all-files