Avoid port collisions when defining port ranges #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
commented
Apr 1, 2022
| @@ -364,7 +368,8 @@ def main( | |||
|
|
|||
| try: | |||
| if listen_address: | |||
| (host, worker_port) = get_address_host_port(listen_address, strict=True) | |||
| host, _ = get_address_host_port(listen_address, strict=True) | |||
| worker_port = str(_) | |||
crusaderky
commented
Apr 1, 2022
| t = Nanny | ||
| else: | ||
| if nanny_port: | ||
| kwargs["service_ports"] = {"nanny": nanny_port} |
There was a problem hiding this comment.
This looks like legacy cruft. service_ports is a property and can't be passed to Worker.__init__.
crusaderky
commented
Apr 1, 2022
| start_arg = self.listener.prefix + unparse_host_port( | ||
| host, self._given_worker_port | ||
| ) | ||
|
|
There was a problem hiding this comment.
worker_start_args does not seem to be used anywhere
|
This is long enough and far enough in a corner of features that I'm probably not going to review it a ton. That being said, and for the same reason, I don't mind if you want to self merge. |
|
I see the test is still failing - I was wrong in my diagnosis. I believe this PR is a very healthy thing to have and should be merged even if it doesn't solve the problem. |
fjetter
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does NOT close #6045