Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug worker client #6059

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Debug worker client #6059

wants to merge 6 commits into from

Conversation

hayesgb
Copy link

@hayesgb hayesgb commented Apr 4, 2022

When a worker_client is created within an async function with separate_thread=True, the secede()call fails, since the running thread is also the main thread. This PR validates that the worker_clientis not running in the main thread before calling secede().

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Unit Test Results

       18 files  ±  0         18 suites  ±0   9h 41m 52s ⏱️ + 19m 28s
  2 702 tests +  5    2 617 ✔️ +  3       82 💤 +1  3 +1 
24 166 runs  +45  22 943 ✔️ +41  1 219 💤 +3  4 +1 

For more details on these failures, see this check.

Results for commit 49fe650. ± Comparison against base commit ccb0362.

@hayesgb hayesgb marked this pull request as draft April 7, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot call worker_client() from an asynchronous function
2 participants