Simplify logic in get_default_compression
#6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite `get_default_compression` in terms of a couple of `if`s. This should make the logic a bit clearer.
Unit Test Results 16 files + 1 16 suites +1 7h 34m 19s ⏱️ + 48m 59s For more details on these failures, see this check. Results for commit a93e19d. ± Comparison against base commit f779854. ♻️ This comment has been updated with latest results. |
|
Planning on merging tomorrow if no comments |
jakirkham
force-pushed
the
cln_get_default_compression
branch
from
defa69d to
a93e19d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
get_default_compressionin terms of a couple ofifs. This should make the logic a bit clearer.pre-commit run --all-files