Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idempotent to register_scheduler_plugin client #6328

Merged
merged 1 commit into from
May 13, 2022

Conversation

asford
Copy link
Contributor

@asford asford commented May 11, 2022

Updates client-side interface of register_scheduler_plugin to pass through idempotent flag.

Extending #5545

Finalizing removal of kwargs support
deprecated in #5699
and removed in #6144

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Updates client-side interface of register_scheduler_plugin to pass through idempotent flag.

Extending dask#5545

Finalizing removal of kwargs support
deprecated in dask#5699
and removed in dask#6144
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

       16 files  +       1         16 suites  +1   7h 19m 26s ⏱️ + 28m 15s
  2 771 tests ±       0    2 692 ✔️ ±       0       78 💤 ±  0  1 ±0 
22 130 runs  +1 577  21 108 ✔️ +1 509  1 021 💤 +69  1  - 1 

For more details on these failures, see this check.

Results for commit 36aa7f3. ± Comparison against base commit 1937be7.

@mrocklin
Copy link
Member

Thanks @asford !

@mrocklin mrocklin merged commit bab29c5 into dask:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants