Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @gen.coroutine with async in Server.close #6365

Closed
wants to merge 3 commits into from

Conversation

hendrikmakait
Copy link
Member

Drop the @gen.coroutine based Server.close method in favor of a native async version.

Refactoring extracted from ongoing work on #6359

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait changed the title Replace @gen.coroutine with async in Server.close Replace @gen.coroutine with async in Server.close May 18, 2022
@github-actions
Copy link
Contributor

Unit Test Results

       6 files   -          9         6 suites   - 9   0s ⏱️ - 7h 5m 19s
   443 tests  -   2 358     395 ✔️  -   2 327    44 💤  -   34    4 +  3 
1 329 runs   - 19 441  1 181 ✔️  - 18 666  136 💤  - 786  12 +11 

For more details on these failures, see this check.

Results for commit 2564924. ± Comparison against base commit 36e9946.

@fjetter fjetter mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant