Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HTTP API by default #6420

Merged
merged 3 commits into from
May 23, 2022
Merged

Disable HTTP API by default #6420

merged 3 commits into from
May 23, 2022

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented May 23, 2022 •
edited
Loading

Workaround for #6407.

Disables the HTTP API by default but allows it to be enabled in environments where auth is handled externally to distributed.

A longer-term fix is to implement some basic HTTP authentication on the API, once that is done #6407 can be closed and the API enabled by default again.

cc @gjoseph92

@jacobtomlinson jacobtomlinson mentioned this pull request May 23, 2022
Closed
gjoseph92
gjoseph92 approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@gjoseph92 gjoseph92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobtomlinson!

@github-actions
Copy link
Contributor

Unit Test Results

       15 files  ±0         15 suites  ±0   7h 9m 19s ⏱️ + 11m 53s
  2 808 tests +1    2 726 ✔️ +1    80 💤 +1  2 ❌  - 1 
20 818 runs  +7  19 886 ✔️ +4  929 💤 +3  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit 5f38479. ± Comparison against base commit d84485b.

@quasiben
Copy link
Member

The only failures here are thetest_stress_scatter_death which is a known issue . I'm going to merge -- thank you @gjoseph92 and @fjetter for the reviews and @jacobtomlinson for the quick fix

FAILED distributed/tests/test_stress.py::test_stress_scatter_death - ValueErr...
= 1 failed, 1481 passed, 108 skipped, 1199 deselected, 12 xfailed, 6 xpassed, 10 leaked in 1850.90s (0:30:50) =

@quasiben quasiben merged commit 00a6445 into dask:main May 23, 2022
@jakirkham jakirkham mentioned this pull request May 23, 2022
Open
2 tasks
@jacobtomlinson jacobtomlinson deleted the disable-http-api branch May 23, 2022 18:39
@jacobtomlinson jacobtomlinson mentioned this pull request May 24, 2022
Open
@jrbourbeau jrbourbeau mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter fjetter approved these changes

@gjoseph92 gjoseph92 gjoseph92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobtomlinson @quasiben @gjoseph92 @fjetter