close client in sync test_actor tests

[graingert]

refs #6453

Not sure if this is a fix, but closing the client explicitly usually helps with unclosed comms

• Tests added / passed
• Passes pre-commit run --all-files

[mrocklin]

Looks good to me. Merging after CI. Any reason to keep this as a draft?

[graingert]

Looks good to me. Merging after CI. Any reason to keep this as a draft?

was waiting for tests, but you're right just moving the client to the with shouldn't need to worry

[mrocklin]

To me Draft state means "the author doesn't yet want this to be merged" and non-green tests means "the robots don't yet want this to be merged". If you think that this is likely going to be ok, pending the review of the bots, then I think it's ok to drop the Draft status. That's just how my thinking works though. Others may have other opinions.

[github-actions]

Unit Test Results

       15 files  ±0         15 suites  ±0   6h 19m 44s ⏱️ - 11m 39s
  2 813 tests ±0    2 733 ✔️ ±0    79 💤 ±0  1 ❌ ±0 
20 854 runs  ±0  19 920 ✔️  - 3  933 💤 +3  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 411dc79. ± Comparison against base commit 5e9e97f.

[mrocklin]

Both failures are test_stress_scatter_death and unrelated. Merging. Thanks for the testing cleanup @graingert !