Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about the profiler when used in tests #6819

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

graingert
Copy link
Member

@graingert graingert commented Aug 2, 2022

Closes #6075

  • Tests added / passed
  • Passes pre-commit run --all-files

@graingert graingert changed the title warn about the profiler when used in tests gh-6075: warn about the profiler when used in tests Aug 2, 2022
@graingert graingert changed the title gh-6075: warn about the profiler when used in tests #6075: warn about the profiler when used in tests Aug 2, 2022
@graingert graingert force-pushed the warn-about-the-profiler-during-tests branch from 1d5b161 to d298c59 Compare August 2, 2022 15:41
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   11h 57m 43s ⏱️ + 5h 11m 48s
  3 041 tests ±0    2 933 ✔️  -   20    83 💤 ±0    20 +  15    5 🔥 +  5 
22 493 runs  ±0  21 314 ✔️  - 201  977 💤 +4  166 +161  36 🔥 +36 

For more details on these failures and errors, see this check.

Results for commit 9244428. ± Comparison against base commit 599708e.

♻️ This comment has been updated with latest results.

@graingert graingert changed the title #6075: warn about the profiler when used in tests warn about the profiler when used in tests Aug 2, 2022
@graingert graingert force-pushed the warn-about-the-profiler-during-tests branch from d298c59 to 4300c10 Compare August 5, 2022 11:59
@graingert
Copy link
Member Author

blocked by #6854

@graingert graingert force-pushed the warn-about-the-profiler-during-tests branch from 98ae153 to 9244428 Compare August 24, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable profiler in tests?
1 participant