Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_worker_who_has_clears_after_failed_connection #6832

Conversation

gjoseph92
Copy link
Collaborator

Closes #6831. This is the "guarantee the worker gets killed before it can transfer the data" approach.

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±    0         15 suites  ±0   6h 33m 22s ⏱️ + 32m 25s
  2 989 tests ±    0    2 898 ✔️ +    1       89 💤 +  1  1  - 3  1 🔥 +1 
22 165 runs  +826  21 118 ✔️ +791  1 044 💤 +36  2  - 2  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 84435c1. ± Comparison against base commit 4af2d0a.

@gjoseph92
Copy link
Collaborator Author

All failures are #6731

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is a good candidate to be rewritten using worker state events w/out actual servers being involved.
Fix looks good enough to me

@fjetter fjetter merged commit ac487b8 into dask:main Aug 5, 2022
gjoseph92 added a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_worker_who_has_clears_after_failed_connection
2 participants