Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show actual Job URL on test report #6837

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 5, 2022

By fetching the Jobs info we can show the URL pointing to the actual job (e.g. OSX noci1)

With this PR

https://github.com/dask/distributed/runs/7666177056?check_suite_focus=true

image

Without

https://github.com/dask/distributed/actions/runs/2794492651

image

It also reduces the size of the HTML page generated by shrinking the DF before rendering. The HTML grew to 10-20MB already

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! cc @ian-r-rose if you get a chance to take a look

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   7h 7m 52s ⏱️ + 35m 2s
  2 990 tests +1    2 900 ✔️ +  1       89 💤 +1  1  - 1 
22 173 runs  +7  21 129 ✔️ +15  1 043 💤  - 5  1  - 3 

For more details on these failures, see this check.

Results for commit 6a50f7f. ± Comparison against base commit d6160c8.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this @fjetter! I think this is looking pretty good. I believe we were already pretty close to hitting the maximum requests-per-hour with this workflow, so we should probably keep an eye on this to make sure the extra requests to the jobs endpoint doesn't tip us over the edge

continuous_integration/scripts/test_report.py Show resolved Hide resolved
continuous_integration/scripts/test_report.py Outdated Show resolved Hide resolved
continuous_integration/scripts/test_report.py Show resolved Hide resolved
continuous_integration/scripts/test_report.py Outdated Show resolved Hide resolved
@fjetter
Copy link
Member Author

fjetter commented Aug 8, 2022

If we hit the API rate limiting I suggest we cache the shelve artifacts which buffer the API requests. Since in this PR we're shelving the raw XML response instead of the parsed dataframe we can do this safely without destroying forward/backwards compatibility of the script and it should be safe to reuse these file caches

Copy link
Collaborator

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @fjetter

@fjetter fjetter merged commit f4b70ae into dask:main Aug 8, 2022
@fjetter fjetter mentioned this pull request Sep 2, 2022
2 tasks
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants