Display unexpected state in Worker.execute validation
#6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gjoseph92
approved these changes
Aug 8, 2022
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 26m 19s ⏱️ + 22m 57s For more details on these failures, see this check. Results for commit 7b71f9e. ± Comparison against base commit bf53760. |
fjetter
approved these changes
Aug 9, 2022
|
The state can legitimately be resumed. We should revert this PR. |
|
The assert was already there before. This PR only added an explanatory message. If the assert statement is wrong, we need create a new PR fixing the assert |
gjoseph92
pushed a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently debugging dask/dask#9330 and found this tiny change to be useful