Drop comparison of versions against all clients #6861
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files + 15 15 suites +15 6h 19m 26s ⏱️ + 6h 19m 26s For more details on these failures, see this check. Results for commit 7a50df1. ± Comparison against base commit 2e928ec. ♻️ This comment has been updated with latest results. |
|
CI flake: #6506 |
distributed/scheduler.py
Outdated
| versions, | ||
| client_name="This Worker", | ||
| source_name=f"Current worker: {ws.server_id}", |
There was a problem hiding this comment.
Does asciitable render a newline properly? Current worker:\n{ws.server_id}
This way we'd reduce horizontal space of the warning by 16 chars
There was a problem hiding this comment.
Let me take a look. IMO, we could also just skip Current worker: entirely. The source should be sufficiently identified by its ID. My guess would be that the formatting wreaks havoc on the formatting since it should break in the middle of the table header.
There was a problem hiding this comment.
Yup, that just messes things up. I'll remove Current worker: so that the message will look like this:
2022-08-10 15:42:31,352 - distributed.worker - WARNING - Mismatched versions found
+---------+---------------------------------------------+----------------------+-----------------------------------+
| Package | Worker-5a4690f1-71ca-4c19-9b3b-22ac5c13674a | Scheduler | Workers |
+---------+---------------------------------------------+----------------------+-----------------------------------+
| dask | 2022.8.0+5.gf7fd6c48 | 2022.8.0+5.gf7fd6c48 | {'2022.8.0+5.gf7fd6c48', '0.0.0'} |
+---------+---------------------------------------------+----------------------+-----------------------------------+
| @@ -105,15 +105,15 @@ def get_package_info( | |||
| return pversions | |||
|
|
|||
|
|
|||
| def error_message(scheduler, workers, client, client_name="client"): | |||
There was a problem hiding this comment.
Driveby: Renamed client to source since the source we want to compare against might be a worker or a client.
There was a problem hiding this comment.
That's fine, I don't think anybody is using this outside of this repo
distributed/scheduler.py
Outdated
| versions, | ||
| client_name="This Worker", | ||
| source_name=f"Current worker: {ws.server_id}", |
There was a problem hiding this comment.
Let me take a look. IMO, we could also just skip Current worker: entirely. The source should be sufficiently identified by its ID. My guess would be that the formatting wreaks havoc on the formatting since it should break in the middle of the table header.
Closes #6536
New logged warning (in
test_version_warning_in_cluster):Out of scope:
Client.get_versionsto check versions against all other clients (follow-up issue: EnableClient.get_versionsto get versions from all other clients and compare against those #6868)pre-commit run --all-files