Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse worker-saturation if a string #7064

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

gjoseph92
Copy link
Collaborator

When set via an env var, it may not end up in the config as a float.

  • Tests added / passed
  • Passes pre-commit run --all-files

When set via an env var, it may not end up in the config as a float.
@gjoseph92 gjoseph92 self-assigned this Sep 23, 2022
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±  0         15 suites  ±0   5h 58m 5s ⏱️ - 4m 29s
  3 114 tests +  2    3 026 ✔️  -   1    85 💤 ±0  3 +3 
23 050 runs  +16  22 140 ✔️ +12  906 💤 ±0  4 +4 

For more details on these failures, see this check.

Results for commit c9c2d15. ± Comparison against base commit 17c70e9.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable -- thanks @gjoseph92

@jrbourbeau jrbourbeau merged commit bd5288c into dask:main Sep 27, 2022
@gjoseph92 gjoseph92 deleted the worker-saturation-str branch October 12, 2022 09:52
gjoseph92 added a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants