Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly recipes with CLI tests, dependency changes #7201

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

charlesbluca
Copy link
Member

Follows up on dask/dask#9600 by adding the relevant CLI tests to the distributed and dask nightly recipes, as well as making some changes to dependency pinnings so that they are consistent with the conda-forge recipes.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 🙏

Had a few questions below

@jakirkham jakirkham requested a review from jrbourbeau October 26, 2022 17:48
Co-authored-by: jakirkham <jakirkham@gmail.com>
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesbluca!

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 35m 47s ⏱️ + 29m 18s
  3 157 tests ±0    3 064 ✔️  - 2    84 💤 +1    9 +1 
23 356 runs  ±0  22 427 ✔️  - 6  902 💤 +3  27 +3 

For more details on these failures, see this check.

Results for commit 948aa3e. ± Comparison against base commit 5dccad4.

@jakirkham
Copy link
Member

There are some other CI failures, but not related to the changes here. Only the Conda changes are relevant (and that specific CI job passes). Going to go ahead and merge. Can revisit if we missed something. Thanks all! 🙏

@jakirkham jakirkham merged commit 621994e into dask:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants