Fix flaky test_include_communication_in_occupancy
#7212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion would sometimes fail, and
occ3
would be some number like0.020008087158203125
distributed/distributed/tests/test_scheduler.py
Lines 1506 to 1507 in 581b603
On slower CI (macOS), the worker would have a chance to heartbeat before that line, updating the
max_exec_time
. When the duration average is unknown but themax_exec_time
is known, we use that to calculate occupancy.Adding an
await asyncio.sleep(0.5)
above that line was a reliable way to make the test always fail.pre-commit run --all-files