Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_include_communication_in_occupancy #7212

Merged

Conversation

gjoseph92
Copy link
Collaborator

This assertion would sometimes fail, and occ3 would be some number like 0.020008087158203125

# Occ should be 2 * 0.5 (CPU, unknown)
assert occ3 == 1

On slower CI (macOS), the worker would have a chance to heartbeat before that line, updating the max_exec_time. When the duration average is unknown but the max_exec_time is known, we use that to calculate occupancy.

Adding an await asyncio.sleep(0.5) above that line was a reliable way to make the test always fail.

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 41m 20s ⏱️ + 14m 36s
  3 160 tests ±0    3 074 ✔️ +1    83 💤 ±0  3  - 1 
23 380 runs  ±0  22 476 ✔️ +3  900 💤 +1  4  - 4 

For more details on these failures, see this check.

Results for commit 3fae185. ± Comparison against base commit 581b603.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: This was meant to be an approval.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gjoseph92!

@fjetter fjetter merged commit 9c8ff86 into dask:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants