Round-robin empty workers with queueing enabled #7222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoseph92
commented
Oct 28, 2022
| min_v: float | None = None | ||
| for cws in dict.values(self.idle): | ||
| # ^ micro-optimization: `SortedDict` inherits from plain `dict`; iterating | ||
| # in non-sorted order is 10x faster and order doesn't matter here. |
There was a problem hiding this comment.
The 10x number comes from here #4925 (comment)
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 14m 14s ⏱️ - 14m 35s For more details on these failures, see this check. Results for commit c578cb2. ± Comparison against base commit 02b9430. ♻️ This comment has been updated with latest results. |
2 tasks
gjoseph92
force-pushed
the
queue-round-robin
branch
from
b000b16 to
c578cb2
Compare
|
Another possible approach: |
|
I'm leaning towards #7248. I think that's more sensible. This special case isn't very important, and we're going to remove the test for it anyway: #7221 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With queuing enabled, when multiple workers have 0 tasks, rather than always picking the first of the empty workers each time, this implements round-robin logic. This ensures that when you're occasionally submitting a few tasks to an idle cluster, the same workers aren't used each time.
See #4637, #4638 for equivalent behavior with queuing disabled.
Requires #7221.
Closes #7197.
pre-commit run --all-files