Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid expensive occupancy calculation when unused #7257

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

gjoseph92
Copy link
Collaborator

Until #7256 is resolved, this helps avoid the expensive calculation unless we really need it.

  • Tests added / passed
  • Passes pre-commit run --all-files

@gjoseph92 gjoseph92 mentioned this pull request Nov 3, 2022
11 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files         15 suites   6h 20m 46s ⏱️
  3 169 tests   3 082 ✔️   84 💤 3
23 448 runs  22 543 ✔️ 901 💤 4

For more details on these failures, see this check.

Results for commit fc18054.

@gjoseph92 gjoseph92 self-assigned this Nov 3, 2022
gjoseph92 added a commit to gjoseph92/snakebench that referenced this pull request Nov 4, 2022
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gjoseph92!

@gjoseph92 gjoseph92 merged commit eb96593 into dask:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants