-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transfer_outgoing_bytes_total
metric
#7388
Conversation
FYI |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 18 files ±0 18 suites ±0 7h 48m 2s ⏱️ - 34m 11s For more details on these failures, see this check. Results for commit 7249762. ± Comparison against base commit 653b006. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjoseph92, this generally looks good to me. I'd slightly change the wording to clarify what we measure here.
Additionally, I wonder if we should extend this metric with a state
label with three states like attempted
, succeeded
and failed
. This would allow us to resolve the issue mentioned in #6936 (comment) and would allow us to drop the corresponding gauge, i.e., requested - (succeeded + failed) = in-progress
. I'd leave this for future work though since it can be generalized to all the transfer
metrics. (I assume that we are fine with totally breaking changes for new metrics, see #7385.)
@ntabris' nit around _total
matches what I propose in #7374, but it doesn't hurt for now.
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
Closes #7123
cc @hendrikmakait @crusaderky @ntabris
pre-commit run --all-files