-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return results in restart_workers
#7606
Return results in restart_workers
#7606
Conversation
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 24 files + 1 24 suites +1 11h 20m 32s ⏱️ + 9m 8s For more details on these failures, see this check. Results for commit 1cde09b. ± Comparison against base commit 8585f98. ♻️ This comment has been updated with latest results. |
There appears to be at least one related failure in Most of the failing tests are fixed by #7595. If you merge main/rebase this should look much better |
restart_workers
5359651
to
d452e30
Compare
d452e30
to
1cde09b
Compare
add to allowlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger! This is in
Also, I noticed this is your first code contribution to this repository. Welcome!
Sorry to "reopen" this. I believe we should add tests for a couple of cases with failing worker restarts. This is where this feature actually comes in handy. |
Makes sense -- @milesgranger would you mind adding some failing worker restarts test cases? |
Small extension to #7154 to return results from
Client.restart_workers
pre-commit run --all-files
Wasn't completely sure if testing an exception raised during restart ought to be handled here, but prior conversations suggest it can be ignored or otherwise logged as is.