-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adjusting GIL monitoring interval #7650
Support adjusting GIL monitoring interval #7650
Conversation
Adjust schema to support enabling and interval value
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files ± 0 26 suites ±0 12h 17m 4s ⏱️ - 29m 31s For more details on these failures, see this check. Results for commit 27b7eb8. ± Comparison against base commit 6cab0e2. This pull request removes 3 and adds 33 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @milesgranger! We're now getting
distributed/tests/test_system_monitor.py::test_gil_contention - TypeError: KnockKnock.__new__() got an unexpected keyword argument 'polling_interval_micros'
in CI. My guess is we need to set a pin on the version of gilknocker
that gets installed
Other than the related test failure, this PR looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @milesgranger -- will merge after CI is done
Augment the configuration schema to support
adjusting the GIL monitoring interval.
Part of #7290
pre-commit run --all-files