Specify ts resolution explicitly in test_processing_chain
#7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 26 files ±0 26 suites ±0 14h 5m 18s ⏱️ - 41m 0s For more details on these failures and errors, see this check. Results for commit a0a7164. ± Comparison against base commit dac5923. |
|
add to allowlist |
|
Outstanding failure is related to join |
jrbourbeau
changed the title
ts resolution explicitly in test_processing_chain
fjetter
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #xxxx
pre-commit run --all-filesWith pandas 2.0 the resolution is inferred based on the resolution of the
np.datetimescalar. This results insresolution, but pyarrow loses said resolution when roundtripping (apache/arrow#33321). Sensible fix here is to specifynsresolution.