Skip to content

Avoid deprecated pd.api.types.is_sparse #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2023

Conversation

jrbourbeau
Copy link
Member

is_sparse has been deprecated in pandas main and using an isinstance(..., pd.SparseDtype) check is now recommented (xref pandas-dev/pandas#52642).

Found this via

FAILED dask/tests/test_distributed.py::test_map_partitions_df_input - FutureWarning: is_sparse is deprecated and will be removed in a future version. Check `isinstance(dtype, pd.SparseDtype)` instead.

in the dask/dask upstream build (which uses the nightly version of pandas)

@jrbourbeau jrbourbeau requested a review from fjetter as a code owner May 1, 2023 15:58
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  ±       0         26 suites  ±0   14h 42m 41s ⏱️ - 24m 8s
  3 559 tests ±       0    3 449 ✔️  -     3     105 💤 ±  0  5 +3 
44 034 runs   - 1 007  41 950 ✔️  - 963  2 078 💤  - 47  6 +3 

For more details on these failures, see this check.

Results for commit dfaeed7. ± Comparison against base commit 43b2a7b.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jrbourbeau!

@hendrikmakait hendrikmakait merged commit 19ce5ba into dask:main May 2, 2023
@jrbourbeau jrbourbeau deleted the is-sparse-dep branch May 2, 2023 15:07
milesgranger pushed a commit to milesgranger/distributed that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants