Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review user-defined fine performance metrics #7894

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

crusaderky
Copy link
Collaborator

User-defined metrics can

  • use any msgpack-serializable Hashable as label
  • use any arbitrary string as unit

This creates edge cases that insofar were poorly tested.

This PR also removes special handling of tuple labels, which caused the execute tuples to become of unpredictable length which created even more edge cases to be tested - this time, needlessly so.

@crusaderky crusaderky requested a review from fjetter as a code owner June 8, 2023 11:52
@crusaderky crusaderky self-assigned this Jun 8, 2023
@crusaderky crusaderky requested a review from milesgranger June 8, 2023 11:54
Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±  0         20 suites  ±0   11h 42m 17s ⏱️ - 8m 52s
  3 677 tests +  2    3 567 ✔️ +  4     108 💤 ±0  2  - 2 
35 560 runs  +20  33 794 ✔️ +22  1 764 💤 ±0  2  - 2 

For more details on these failures, see this check.

Results for commit 4a1e50f. ± Comparison against base commit e31c864.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_cumulative_worker_metrics
distributed.tests.test_worker_metrics ‑ test_reschedule
distributed.tests.test_worker_metrics ‑ test_send_metrics_to_scheduler
distributed.tests.test_worker_metrics ‑ test_user_metrics_weird

Co-authored-by: Miles <miles59923@gmail.com>
@crusaderky crusaderky merged commit 36c9121 into dask:main Jun 8, 2023
@crusaderky crusaderky deleted the custom_metrics branch June 8, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants