Rename get_default_shuffle_algorithm to get_default_shuffle_method
#7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
changed the title
get_default_shuffle_algorithm to get_default_shuffle_method
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 12h 27m 54s ⏱️ + 4m 37s For more details on these failures, see this check. Results for commit 47c4fcd. ± Comparison against base commit 19c8bf9. ♻️ This comment has been updated with latest results. |
3 tasks
hendrikmakait
commented
Jun 12, 2023
| @@ -43,7 +43,8 @@ dependencies: | |||
| - zict # overridden by git tip below | |||
| - zstandard >=0.9.0 | |||
| - pip: | |||
| - git+https://github.com/dask/dask | |||
| # - git+https://github.com/dask/dask | |||
| - git+https://github.com/hendrikmakait/dask.git@default-shuffle-ignores-fuse | |||
There was a problem hiding this comment.
Just flagging: Revert me
phofl
approved these changes
Jun 13, 2023
This reverts commit 47c4fcd.
hendrikmakait
added a commit
to hendrikmakait/distributed
that referenced
this pull request
Jun 13, 2023
hendrikmakait
added a commit
that referenced
this pull request
Jun 13, 2023
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Jun 13, 2023
In dask/distributed#7902 the name `get_default_shuffle_algorithm` has been changed to `get_default_shuffle_method`, which is adjust by this change.
pentschev
added a commit
to pentschev/dask-cuda
that referenced
this pull request
Jun 13, 2023
In dask/distributed#7902 the name `get_default_shuffle_algorithm` has been changed to `get_default_shuffle_method`, which is adjusted by this change.
rapids-bot bot
pushed a commit
to rapidsai/dask-cuda
that referenced
this pull request
Jun 13, 2023
In dask/distributed#7902 the name `get_default_shuffle_algorithm` has been changed to `get_default_shuffle_method`, which is adjusted by this change. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) URL: #1200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling to dask/dask#10344
pre-commit run --all-files