Ensure adaptive properties work as expected for SpecCluster #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 14h 20m 34s ⏱️ - 53m 8s For more details on these failures, see this check. Results for commit 12835e6. ± Comparison against base commit 76dd800. |
|
@fjetter: What's the status here? Do you need me to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering in which we mutate
Cluster.workersinCluster._correct_state_internalhas an impact on how the adaptive propertiesplan,requested,observedbehave.#8233 changed this ordering in a way that is incompatible with the meaning of those properties but apparently this is not tested.
#8314 is proposing to introduce another ordering change that is incompatible with this.
This unit test should guarantee that the definition of those properties is respected.