-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent hashing for Nanny-spawned workers #8400
Conversation
Can one of the admins verify this patch? Admins can comment |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 11h 45m 14s ⏱️ - 2m 44s For more details on these failures, see this check. Results for commit acc5075. ± Comparison against base commit 87576ae. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
This pull request skips 2 tests.
♻️ This comment has been updated with latest results. |
There is one related test failure in You're also affected by #8397 Otherwise this LGTM. If you can adjust the failing test we can merge |
Thanks so much for the prompt review @fjetter! The last commit fixes the broken test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up the tests @cisaacstern. Failures we see now look unrelated tot his change.
Thanks @jacobtomlinson and @fjetter ! |
Towards #4141
pre-commit run --all-files
This PR implements @mrocklin's suggestion in #4141 (comment) to replicate dask/dask#6660, but for Nanny-spawned workers. As noted there, this is not a complete solution for #4141, as the Nanny is not required for spawning workers, but nonetheless should unblock a large percentage of uses cases currently blocked by #4141.
First commit is just a failing test, will push the fix momentarily.