Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert_eq import from cudf #8747

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

jrbourbeau
Copy link
Member

gpuCI is failing with errors like this

13:20:30 ________________________ test_ping_pong_cudf[<lambda>8] ________________________
13:20:30 

13:20:30 ucx_loop = <_UnixSelectorEventLoop running=False closed=False debug=False>
13:20:30 g = <function <lambda> at 0x7f708ff1a660>
13:20:30 

13:20:30     @pytest.mark.parametrize(
13:20:30         "g",
13:20:30         [
13:20:30             lambda cudf: cudf.Series([1, 2, 3]),
13:20:30             lambda cudf: cudf.Series([], dtype=object),
13:20:30             lambda cudf: cudf.DataFrame([], dtype=object),
13:20:30             lambda cudf: cudf.DataFrame([1]).head(0),
13:20:30             lambda cudf: cudf.DataFrame([1.0]).head(0),
13:20:30             lambda cudf: cudf.DataFrame({"a": []}),
13:20:30             lambda cudf: cudf.DataFrame({"a": ["a"]}).head(0),
13:20:30             lambda cudf: cudf.DataFrame({"a": [1.0]}).head(0),
13:20:30             lambda cudf: cudf.DataFrame({"a": [1]}).head(0),
13:20:30             lambda cudf: cudf.DataFrame({"a": [1, 2, None], "b": [1.0, 2.0, None]}),
13:20:30             lambda cudf: cudf.DataFrame({"a": ["Check", "str"], "b": ["Sup", "port"]}),
13:20:30         ],
13:20:30     )
13:20:30     @gen_test()
13:20:30     async def test_ping_pong_cudf(ucx_loop, g):
13:20:30         # if this test appears after cupy an import error arises
13:20:30         # *** ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.11'
13:20:30         # not found (required by python3.7/site-packages/pyarrow/../../../libarrow.so.12)
13:20:30         cudf = pytest.importorskip("cudf")
13:20:30 >       from cudf.testing._utils import assert_eq
13:20:30 E       ImportError: cannot import name 'assert_eq' from 'cudf.testing._utils' (/opt/conda/envs/dask/lib/python3.11/site-packages/cudf/testing/_utils.py)
13:20:30 

13:20:30 distributed/comm/tests/test_ucx.py:201: ImportError

Based on rapidsai/cudf#16063 I think we should use from cudf.testing import assert_eq. Though I'm not really sure -- let's see if this helps CI.

cc @rjzamora @wence- @charlesbluca for visibility

@jrbourbeau jrbourbeau requested a review from fjetter as a code owner July 3, 2024 21:54
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrbourbeau !

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   11h 12m 49s ⏱️ - 3m 39s
 4 083 tests ±0   3 966 ✅ +4    112 💤 ±0  5 ❌  - 4 
55 230 runs  ±0  52 792 ✅ +4  2 432 💤 ±0  6 ❌  - 4 

For more details on these failures, see this check.

Results for commit 054d814. ± Comparison against base commit 9d36228.

@jrbourbeau jrbourbeau merged commit 86ef1b9 into dask:main Jul 5, 2024
31 of 37 checks passed
@jrbourbeau jrbourbeau deleted the cudf-assert_eq_fixup branch July 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants