See what happens if we don't track thrift i32 #925
+18
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves local file opening speed by 15% for large metadata (including byte reading and thrift parsing, but only the latter is actually affected).
This will cause data corruption in the case that a thrift object is directly written from one that is read, rather than created afresh. I believe this only happens in ParquetFile.remove/write_row_groups , which (rare events) must make sure to add i32 fields to the object dictionaries.